You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do not run the clustering on ROF that do not contain enough pre-clusters on enough chambers to potentially reconstruct a track afterward.
Do not consider in this filtering the pre-clusters made of only 1 digit since they are skipped in the clustering.
Also modify the trackable ROF filtering based on digits at the end of the time clustering to require at least 2 digits (instead of 1) on enough chambers, in order to filter out as much ROF as possible from the beginning.
This reduces the number of reconstructed ROF by ~30% in pp (~23% in PbPb) and speed-up the clustering as well as reduces the number of reconstructed clusters by ~12% in pp (~8% in PbPb). It also slightly speed-up the tracking in pp by ~2%.
Hello @ppillot,
Thanks, the code looks good to me. I am just asking if we want to do the merging now.
I know there are new tags created for pp 2026 (not sure if via cherry picking or from the tag of the master), and there will be probably a new one for PbPb 2026.
I understand that the changes you made shouldn't affect the tracking efficiency as you are just filtering clusters that would not make it inside a track. Let me know your opinion if you think it is ok to change the reco already now or if it is better to wait the end of Run 3 data taking.
Cheers,
Laure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not run the clustering on ROF that do not contain enough pre-clusters on enough chambers to potentially reconstruct a track afterward.
Do not consider in this filtering the pre-clusters made of only 1 digit since they are skipped in the clustering.
Also modify the trackable ROF filtering based on digits at the end of the time clustering to require at least 2 digits (instead of 1) on enough chambers, in order to filter out as much ROF as possible from the beginning.
This reduces the number of reconstructed ROF by ~30% in pp (~23% in PbPb) and speed-up the clustering as well as reduces the number of reconstructed clusters by ~12% in pp (~8% in PbPb). It also slightly speed-up the tracking in pp by ~2%.